New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make linear frontend consistent with mel #77

Open

auroracramer opened this issue Aug 10, 2021 · 0 comments

Labels

bug

Collaborator

auroracramer commented Aug 10, 2021

The linear frequency spectrogram frontend results in 197 frames instead of 199, which seems to be caused by:

In _librosa_linear_frontend (openl3/core.py), center=False should be center=True when calling librosa.stft
In _construct_linear_audio_network (openl3/models.py), pad_end=True should be added to argument for __fix_kapre_spec
In _construct_linear_audio_network (openl3/models.py), in the else block corresponding to if include_frontend, the input_shape should account for centering

In addition to fixing these, we'll need to regenerate the regression data likely

The text was updated successfully, but these errors were encountered:

auroracramer added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment