Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the codebase to be more modular #7

Open
markusaksli opened this issue Mar 22, 2021 · 2 comments · May be fixed by #29
Open

Rework the codebase to be more modular #7

markusaksli opened this issue Mar 22, 2021 · 2 comments · May be fixed by #29
Assignees
Labels
p: change Relates to refactoring or changing TradeBot P3 Default for new feature requests and minor issues proposal Proposal for a change or new feature

Comments

@markusaksli
Copy link
Owner

markusaksli commented Mar 22, 2021

Rework the entire current codebase to be essentially a backend instead of the current basic console app standalone solution.

  • The printed information needs to be returned in the relevant methods instead of being printed.
  • Use streams and listeners for constantly updating information (collection progress, trade events, etc)
  • Get rid of modes (or at least be able to switch between them)
  • Generate logs using an appropriate logging solution like log4j

This is the prerequisite for #8. This means the console exe with launch4j can be replaced with a different front-end. Once this is done the bot backend could also be entirely detached from the local executable, run as a server, and communicate via API responses.

@markusaksli markusaksli added P4 Unlikely to work on soon p: change Relates to refactoring or changing TradeBot proposal Proposal for a change or new feature P3 Default for new feature requests and minor issues and removed P4 Unlikely to work on soon labels Mar 22, 2021
@markusaksli markusaksli mentioned this issue Apr 12, 2021
@ramarro123
Copy link

hi @markusaksli i also suggest you to remove static classes BuySell, Trade, Simulator, and make them object, in this way it will be possible to spawn multiple simulator at once, making everything self contained

@markusaksli
Copy link
Owner Author

@ramarro123 I'm working on this right now in the v11 branch

https://github.com/markusaksli/TradeBot/blob/v11/src/main/java/trading/Instance.java

It's still pretty incomplete but let me know if this fits the general idea

@markusaksli markusaksli self-assigned this May 10, 2021
@markusaksli markusaksli linked a pull request May 10, 2021 that will close this issue
@markusaksli markusaksli linked a pull request May 11, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: change Relates to refactoring or changing TradeBot P3 Default for new feature requests and minor issues proposal Proposal for a change or new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants