Skip to content

Latest commit

 

History

History
154 lines (104 loc) · 4.2 KB

DEVELOPING.md

File metadata and controls

154 lines (104 loc) · 4.2 KB
Raw

Developing Sparsify

Sparsify is developed and tested using Python 3.6+. To develop Sparsify, you will also need the development dependencies and to follow the styling guidelines.

Here's some details to get started.

Basic Commands

Development Installation

To develop the Sparsify UI, you will also need to install Node.js and yarn.

git clone https://github.com/neuralmagic/sparsify.git
cd sparsify
python3 -m pip install -e ./[dev]
yarn install

This will clone the Sparsify repo, install sparsify, and install the development dependencies.

Code Styling and Formatting checks

make style
make quality

This will run automatic code styling using prettier for UI code and black and isort for the backend. It also tests that the repository's code matches its style standards.

EXAMPLE: test changes locally

make test

This will run all Sparisfy unit tests. File any error found before changes as an Issue and fix any errors found after making changes before submitting a Pull Request.

GitHub Workflow

  1. Fork the neuralmagic/sparsify repository into your GitHub account: https://github.com/neuralmagic/sparsify/fork.

  2. Clone your fork of the GitHub repository, replacing <username> with your GitHub username.

    Use ssh (recommended):

    git clone git@github.com:<username>/sparsify.git

    Or https:

    git clone https://github.com/<username>/sparsify.git

  3. Add a remote to keep up with upstream changes.

    git remote add upstream https://github.com/neuralmagic/sparsify.git

    If you already have a copy, fetch upstream changes.

    git fetch upstream

  4. Create a feature branch to work in.

    git checkout -b feature-xxx remotes/upstream/main

  5. Work in your feature branch.

    git commit -a

  6. Periodically rebase your changes

    git pull --rebase

  7. When done, combine ("squash") related commits into a single one

    git rebase -i upstream/main

    This will open your editor and allow you to re-order commits and merge them:

    • Re-order the lines to change commit order (to the extent possible without creating conflicts)
    • Prefix commits using s (squash) or f (fixup) to merge extraneous commits.

  8. Submit a pull-request

    git push origin feature-xxx

    Go to your fork main page

    https://github.com/<username>/sparsify

    If you recently pushed your changes GitHub will automatically pop up a Compare & pull request button for any branches you recently pushed to. If you click that button it will automatically offer you to submit your pull-request to the neuralmagic/sparsify repository.

    • Give your pull-request a meaningful title. You'll know your title is properly formatted once the Semantic Pull Request GitHub check transitions from a status of "pending" to "passed".
    • In the description, explain your changes and the problem they are solving.

  9. Addressing code review comments

    Repeat steps 5. through 7. to address any code review comments and rebase your changes if necessary.

    Push your updated changes to update the pull request

    git push origin [--force] feature-xxx

    --force may be necessary to overwrite your existing pull request in case your commit history was changed when performing the rebase.

    Note: Be careful when using --force since you may lose data if you are not careful.

    git push origin --force feature-xxx