New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plan for adding search capabilities? #22
Comments
Work in progress: |
Is there any update on this, aside from the "work in progress" above? |
@e40 - no updates at the moment. It's quite a large body of work to implement this, so I'm not sure when I will be able to take it on. I'm more than happy to accept PRs for search capabilities. On that branch, or with a completely fresh take. There are open design questions around search that should be addressed:
Do you have ideas for this @e40 ? |
@F1LT3R If I may, I'd like to offer my two cents into this discussion.
I think that a search input should be available on every page that has the rest of the theme present, such as any non-raw file, as it would allow for the greatest mobility and ease of use for the user. Also, a hotkey to focus the search input would be nice! Ala, Google, YouTube, etc.
I would personally like to see a snippet of the relevant result entry, just like how GitHub does it with their search. You get the convenience of previewing the matched content and the functionality of increased entries on the page. Best of both worlds!
The search input should not include included files by default, but maybe a dedicated search page (or the results page) should allow the user to enable flags for a more comprehensive search?
Yes, in fact, we could explore some prebuilt or warmed-up cache options. Maybe allow the user to enable a flag on the cli that takes a moment at runtime to precache all markdown files in an easier to search format? If not, we could just cache as it's searched. As for how it should look, I favour simple filesystem caching, such as a
All on the page, and once it searches it should take you to a search/result page, just like the GitHub search flow. |
markserv is a really nice project. Users of my internal documentation are complaining about no search, though. Are there plans to add it? Are there easy ways to use an internal tool to add it? Thanks for creating cool software that is useful and easy to config.
The text was updated successfully, but these errors were encountered: