Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Assistant.Macros.HotKeyAction #207

Open
DemonRok opened this issue Feb 17, 2023 · 5 comments
Open

[Enhancement] Assistant.Macros.HotKeyAction #207

DemonRok opened this issue Feb 17, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@DemonRok
Copy link

DemonRok commented Feb 17, 2023

After last commit, isn't possible to record any HotKeyAction.

@DemonRok DemonRok added the bug Something isn't working label Feb 17, 2023
@markdwags
Copy link
Owner

I'm not able to reproduce. What I tried:

New macro
Click record
Go to Hot Keys tab
Select random hot key (I picked All Names)
Go back to Macros tab and saw recorded hotkeyaction Assistant.Macros.HotKeyAction|1372|

@DemonRok
Copy link
Author

I left out how.
before it was enough to press the hotkey previously set, without moving to the hotkey tab.

As you described it works.

@markdwags
Copy link
Owner

I tried that as well.

  • Assigned all names the key combo of CTRL-A
  • New macro, click record
  • Hit CTRL-A on my keyboard
  • I see "Exec: All Names" get recorded as expected

@markdwags markdwags self-assigned this Feb 18, 2023
@DemonRok
Copy link
Author

I found the difficulty...
Me too, no problem with standard HotKey.
The problem arises when another script is assigned to the hotkey.
There is no possibility to stop the recording as the script assigned to the hotkey is executed.
If, with little patience, you change tab, the recording is empty. On the other hand, if you wait about 30 seconds without changing tab, the recording remains.
As a workaround, it could be made that during recording the selected hotkey does not execute the assigned action or script, so it does not block the possibility of stopping the recording.

@DemonRok
Copy link
Author

I think it's time to change this from bug to enhancement

@DemonRok DemonRok changed the title [BUG] Assistant.Macros.HotKeyAction [Enhancement] Assistant.Macros.HotKeyAction Feb 18, 2023
@markdwags markdwags added enhancement New feature or request and removed bug Something isn't working labels Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants