Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw Exception instead "return;" #52

Open
Slayer911 opened this issue Feb 20, 2020 · 2 comments
Open

Throw Exception instead "return;" #52

Slayer911 opened this issue Feb 20, 2020 · 2 comments

Comments

@Slayer911
Copy link

Please, change this comment to real exception

// Alternatively throw an error here.

When this library is one block of big system, bugs like this is hard detection, if here will be real exception, life will be better, i think

@mark-gerarts
Copy link
Owner

Yes, you are right. However, throwing an exception here could be a backwards incompatible change. I will definitely incorporate this in the 2.0 release though. Thanks for reporting!

@Slayer911
Copy link
Author

Thank for great library)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Release 2.0
  
To do
Development

No branches or pull requests

2 participants