Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing a scalar to map should throw an InvalidArgumentException #28

Open
mark-gerarts opened this issue Oct 9, 2018 · 0 comments
Open

Passing a scalar to map should throw an InvalidArgumentException #28

mark-gerarts opened this issue Oct 9, 2018 · 0 comments
Labels
enhancement good first issue
Projects
Release 2.0

Comments

@mark-gerarts
Copy link
Owner

When for example an array is passed to map, get_class will trigger an error. It would be better to check the type and throw an InvalidArgumentException if needed. In the future, we could add mappings from scalars (such as arrays, #18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
Release 2.0
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mark-gerarts