Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove nullable type from Page::title() #175

Open
mariosimao opened this issue Mar 12, 2023 · 0 comments
Open

[FEATURE] Remove nullable type from Page::title() #175

mariosimao opened this issue Mar 12, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@mariosimao
Copy link
Owner

Describe the solution you'd like

// Page.php
public function title(): Title { ... }

// Pages/Properties/PropertyCollection.php
public function title(): Title { ... }

Additional context
The proposed changes will result in breaking changes. It should be delayed until v2.

@mariosimao mariosimao added the enhancement New feature or request label Mar 12, 2023
@mariosimao mariosimao added this to the v2 milestone Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant