Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined ES5 getters/setters broken again #289

Open
jklmli opened this issue Jun 2, 2015 · 3 comments
Open

undefined ES5 getters/setters broken again #289

jklmli opened this issue Jun 2, 2015 · 3 comments

Comments

@jklmli
Copy link
Contributor

jklmli commented Jun 2, 2015

8b35f9d overrode some of the fixes committed in e869f18
@paulfalgout
Copy link
Member

Hmm.. I think some commenting is in order to prevent this from happening again. Or is there anyway we could accurately test this? Failing tests would be even better. Otherwise I could certainly see this happening again.

@jasonLaster
Copy link
Member

Hmm, yea please submit a fix and comments or tests

@blikblum
Copy link
Contributor

blikblum commented Jul 1, 2017

Anyone knows how to reproduce the issue, so i can add tests?
@jiaweihli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jasonLaster @jklmli @paulfalgout @blikblum