Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying symlink does not work when real source is not relative to parent source #2373

Closed
cedk opened this issue Apr 29, 2024 · 2 comments · Fixed by #2415
Closed

Copying symlink does not work when real source is not relative to parent source #2373

cedk opened this issue Apr 29, 2024 · 2 comments · Fixed by #2415

Comments

@cedk
Copy link
Contributor

cedk commented Apr 29, 2024

Since 48cbd3d including Adwaita icons does not work anymore on macOS with Homebrew.

For example in Homebrew the icon /opt/homebrew/share/icons/Adwaita/cursors/bottom_side is a symlink to ../../../../Cellar/adwaita-icon-theme/46.0/share/icons/Adwaita/cursors/bottom_side.
With _pre_copy_hook, it is (PosixPath('/Users/ced/tryton-7.2/tryton/build/exe.macosx-14.0-arm64-3.12/share/icons/Adwaita/cursors/bottom_side'), PosixPath('../../../../Cellar/adwaita-icon-theme/46.0/share/icons/Adwaita/cursors/s-resize'), False) that is stored in _symlinks. The symlink target does not exist in the build folder.

I think that if the source symlink is not included it should make a copy.

@marcelotduarte
Copy link
Owner

marcelotduarte commented May 21, 2024

Please test with the latest development build:
pip install --force --no-cache --pre --extra-index-url https://marcelotduarte.github.io/packages/ cx_Freeze

and give me feedback.

If it does not work, you can resolve the links in the setup. For example, you can change:
https://github.com/tryton/tryton/blob/main/tryton/setup-freeze.py#L34
To use realpath or Path.resolve:
Path(sys.prefix, 'share', 'icons', 'Adwaita').resolve()

@marcelotduarte marcelotduarte linked a pull request May 22, 2024 that will close this issue
@marcelotduarte
Copy link
Owner

Release 7.1.0 is out!
Documentation

Assuming resolved. If you have any issues, please report them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants