Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Out of sync element ids on events #609

Merged
merged 4 commits into from
May 17, 2024

Conversation

marc2332
Copy link
Owner

Fixes #608

@marc2332 marc2332 added the fix 🩹 Fixes a bug label May 12, 2024
Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.28%. Comparing base (885959c) to head (a20722d).
Report is 2 commits behind head on main.

Current head a20722d differs from pull request most recent head 0bc66df

Please upload reports for the commit 0bc66df to get more accurate results.

Files Patch % Lines
crates/testing/src/test_handler.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
- Coverage   73.29%   73.28%   -0.01%     
==========================================
  Files         192      192              
  Lines       19177    19177              
==========================================
- Hits        14055    14054       -1     
- Misses       5122     5123       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review May 15, 2024 19:23
@marc2332 marc2332 merged commit 0bc8d3e into main May 17, 2024
4 of 6 checks passed
@marc2332 marc2332 deleted the fix/out-of-sync-element-ids-on-events branch May 17, 2024 21:55
@github-actions github-actions bot mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Queued events could be wrongly emitted to Elements whose ElementId (VirtualDOM ID) have been reused
1 participant