Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Queued events could be wrongly emitted to Elements whose ElementId (VirtualDOM ID) have been reused #608

Closed
marc2332 opened this issue May 12, 2024 · 1 comment · Fixed by #609
Assignees
Labels
bug 😔 Something isn't working

Comments

@marc2332
Copy link
Owner

This is a very weird edge case that makes the VirtualDOM fire events on Elements that have been removed and whose ElementId have been reused.

I simply need to retrieve the ElementId just before calling vdom.handle_event instead of getting it in events_measurer.

@marc2332 marc2332 added the bug 😔 Something isn't working label May 12, 2024
@marc2332 marc2332 self-assigned this May 12, 2024
@marc2332
Copy link
Owner Author

This will mostly occur with keydown events, which will be queued in most cases and not bubble up, leading to the problem described above.

@marc2332 marc2332 changed the title bug: Events in queue could be wrongly emitted to Elements whose ElementId (VirtualDOM ID) have been reused bug: Queued events could be wrongly emitted to Elements whose ElementId (VirtualDOM ID) have been reused May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 😔 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant