remove_all does not remove cache

[rkucmierowski]

Context

Is everything ok with remove_all cleanuping option for file cache?
According docs: When set to true (...) it will remove complete level directories for file caches instead of comparing each tile with a timestamp.

Actual Behavior

But if remove_all is set to True,
max_mtime = self.expire_timestamp(tile) equals 0 and tiles timestamp comparison is still performed,
so the condition stale = int(tile.timestamp) <= max_mtime evaluates to False and is_cached() returns True.

mapproxy/mapproxy/cache/tile.py

Lines 228 to 245 in f3b976d

	def is_cached(self, tile, dimensions=None):
	"""
	Return True if the tile is cached.
	"""
	if isinstance(tile, tuple):
	tile = Tile(tile)
	if tile.coord is None:
	return True
	cached = self.cache.is_cached(tile, dimensions=dimensions)
	max_mtime = self.expire_timestamp(tile)
	if cached and max_mtime is not None:
	self.cache.load_tile_metadata(tile)
	# file time stamp must be rounded to integer since time conversion functions
	# mktime and timetuple strip decimals from seconds
	stale = int(tile.timestamp) <= max_mtime
	if stale:
	cached = False
	return cached

Then is_stale() returns False, which means that the tile has not expired and shouldn't be remove

mapproxy/mapproxy/cache/tile.py

Lines 247 to 259 in f3b976d

	def is_stale(self, tile, dimensions=None):
	"""
	Return True if tile exists _and_ is expired.
	"""
	if isinstance(tile, tuple):
	tile = Tile(tile)
	if self.cache.is_cached(tile, dimensions=dimensions):
	# tile exists
	if not self.is_cached(tile, dimensions=dimensions):
	# expired
	return True
	return False
	return False

Your Environment

Version used: MapProxy 1.16
Environment name and version: Python 3.7
Server type and version:
Operating System and version: Ubuntu

[simonseyock]

Thanks for reporting this! In my opinion the behavior of is_cached is correct, but is_stale should return True instead of False. I will look into this.

Edit: I think the description of is_cached is wrong and should actually be: Return True if the tile exists _and_ is not expired.

[simonseyock]

I assume you mean the remove_all option of the seeding cleanup tasks https://mapproxy.github.io/mapproxy/latest/seed.html#remove-all

There exists a test that covers exactly this case for the tile cache:
https://github.com/mapproxy/mapproxy/blob/master/mapproxy/test/system/test_seed.py#L193

The functions is_cached and is_stale are never called in this case. Can you provide further information about your configuration?