Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing reference to self when setting cache_dir for file cache when dimensions is supplied #804

Open
shimoncohen opened this issue Dec 1, 2023 · 2 comments
Open

Missing reference to self when setting cache_dir for file cache when dimensions is supplied #804

shimoncohen opened this issue Dec 1, 2023 · 2 comments

Comments

@shimoncohen
Copy link
Contributor

@weskamm It looks like this line was meant to set self.cache_dir but is missing self.
https://github.com/mapproxy/mapproxy/blob/4315ecab0ab42031de4928c751b04995603a5b1b/mapproxy/cache/file.py#L54C13-L54C23
@simonseyock
Copy link
Contributor

Ah, I see you stumbled upon that line as well :)
I think it should be used instead of self.cache_dir in the following line

@shimoncohen
Copy link
Contributor Author

No problem, I'll fix this in my PR fixing #796.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonseyock @shimoncohen