Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation or source for SoilGrids #99

Open
fBedecarrats opened this issue Sep 4, 2022 · 2 comments
Open

Update documentation or source for SoilGrids #99

fBedecarrats opened this issue Sep 4, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@fBedecarrats
Copy link
Collaborator

Hi there!
I was reviewing the soilgrids indicators. The function documentation refers to the 2017 PLOS One paper, which corresponds to a ~60% accuracy. The new generation of SoilGrids displays an accuracy > 90% and there is a corresponding publication in the SOIL journal.
Is it possible to ensure that the mapme.biodiversity packages fetches its data from the 2.0 version of SoilGrid, and refer to the 2021 paper, that includes an updated information?
Best regards,
FB
PS : there is a typo at the beginning of the function documentation: it should read "each parameter is mapped" (currently it reads "each parapeters is mapped")

@goergen95
Copy link
Member

The URL points towards the latest release, see:

baseurl <- "/vsicurl/https://files.isric.org/soilgrids/latest/data/"

If I understand the README.md correctly, this points towards v2.0. So only the documentations needs some changes.

@fBedecarrats
Copy link
Collaborator Author

Hi there,
I understand too that it refers to the 2.0 version to soilgrids. Then my suggestion would be to update the "reference" section of the soilgrids function documentation to point to the SOIL paper instead of the PLOS ONE paper.

@Jo-Schie Jo-Schie added the good first issue Good for newcomers label Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants