Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove magrittr dependency #98

Open
goergen95 opened this issue Aug 23, 2022 · 4 comments
Open

Remove magrittr dependency #98

goergen95 opened this issue Aug 23, 2022 · 4 comments

Comments

@goergen95
Copy link
Member

Currently the magrittr pipe is used not within the package code but only in the examples. I suggest removing this dependency and use the native pipe instead either for the upcoming 0.2.0 release (which hopefully means today) or in an upcoming release. This would mean that the package would require R>=4.1.0. Any thoughts, @Ohm-Np and @Jo-Schie?

@Jo-Schie
Copy link
Member

Not sure. I think a lot of people may still have R 4.0.X or even lower. Forcing people to upgrade can be a bummer. At least I was often kind of frustrated when having to do so. If it is only for one dependency I'd rather keep it...

@goergen95
Copy link
Member Author

goergen95 commented Aug 23, 2022

Thing is its one dependency which is not really useful and costs computational resources (for our workflows here on GA and on CRAN e.g. for reverse dependency checks etc.). Since we now have a pipe in base R I think its kind of useless to only import magrittr for that reason. Of course I understand that some users are then forced to update their R installation, but I don't see many reasons for people to use 3.x, question is if they should if there has been a new major release... Additionally, since our package is quite new I don't think that we have to consider backwards-compability for older R versions at this point. I would suggest to consider this for the next release so that we can sort our thoughts on this?

@Jo-Schie
Copy link
Member

humm...I'm really unsure. If you force people to upgrade R you also force them to reinstall all of their packages (which sometimes even doesnt work). On Linux you have additional hurdles because the current version in e.g. the ubuntu repos is 3.6 so people need to add PPA and go through all of this stuff. I generally agree that we should remove this dependency, but can we not postpone it until more people have R 4.X ? So it would be not in the release your currently preparing but then maybe in a couple of month?

@goergen95
Copy link
Member Author

agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants