Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react18] Replace react-aria-menubutton with react-select #846

Open
birkskyum opened this issue Dec 20, 2023 · 4 comments
Open

[react18] Replace react-aria-menubutton with react-select #846

birkskyum opened this issue Dec 20, 2023 · 4 comments

Comments

@birkskyum
Copy link
Member

I tried to update react, and react-aria-menubutton complained it isn't compatible with latest react.

We should probably just swap it. Long story short react-aria-menubutton became less relevant in 2021 with the rise of downshift, which itself got overtaken by react-select last few years.

Screenshot 2023-12-20 at 21 03 44 Screenshot 2023-12-20 at 21 04 14 Screenshot 2023-12-20 at 21 04 37
@birkskyum birkskyum changed the title Replace react-aria-menubutton with react-select [bump react] Replace react-aria-menubutton with react-select Dec 20, 2023
@birkskyum birkskyum changed the title [bump react] Replace react-aria-menubutton with react-select [react18] Replace react-aria-menubutton with react-select Dec 20, 2023
@HarelM
Copy link
Member

HarelM commented Dec 20, 2023

I think the path forward is first to use typescript, otherwise updating dependencies will cause things to break only in run time.
It shouldn't take long to upgrade to typescript.
After that we can swap packages.
I also think there's a need to use a component library instead of the proprietary components written here and the storybook here which I have no clue why we should maintain it.
But it might be just me...
Feel free to review my typescript PRs to streamline the migration to typescript.

@birkskyum
Copy link
Member Author

birkskyum commented Dec 20, 2023 •
edited

that's a good idea, and awesome that it's possible to transition with vite in place. on that note react-select has proper typing too, but it's a good idea to use a component library

@HarelM
Copy link
Member

HarelM commented Dec 26, 2023

Migration is complete, lint is complete, feel free to push this forward.
The most well known component library for react that might be a good idea to use is MUI.
But I don't have a lot of experience with react to actually say something significant here.

@HarelM
Copy link
Member

HarelM commented Mar 21, 2024

@birkskyum I've created a PR to update react to version 18.
See here:

Can you tell me what I should check in order to see the issue?

@HarelM HarelM mentioned this issue Mar 21, 2024
Merged
5 tasks
HarelM added a commit that referenced this issue Mar 21, 2024
@HarelM
Update React to version 18 and other deps (#890)
ff15b77 
This PR aims at updating some packages.
I'll keep this in draft until I'll be more happy with the results.
Current setup seems to work, I'll let the CI run and see how bad this
is.
Packages that needs to be updated/replaces:
- [x] ~autocompete - The only warning left in the console is related to
the autocomplete, which probably needs to be updated since it's a
package that wasn't updated in the last 6 years.~ #611
- [x] ~Codemirror is also something that will need an update, but it
looks too complicated at this point in time, so let's see how this
goes.~ #891
- [ ] react-color
- [x] ~react-aria-menubutton~ #846
- [ ] Others?

Most of the changes here are related to types, which is good.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HarelM @birkskyum