Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show marker tickboxes for items with true as default #747

Open
zstadler opened this issue Jan 28, 2021 · 0 comments
Open

Show marker tickboxes for items with true as default #747

zstadler opened this issue Jan 28, 2021 · 0 comments
Labels

Comments

@zstadler
Copy link
Collaborator

Maputnik version: v1.7.0
Browser: Firefox
OS: Windows

Description of the bug:
The following style elements default to true:

However, the GUI representation of the default is a unchecked tickbox rather than a checked tickbox. As a result, when the default is used, the checkbox is clear, but the proprty is true/active.

Steps to reproduce the behavior:

  1. Open https://maputnik.github.io/editor/#15/31.25102/35.12409
  2. Upload this URL style.
  3. Select the contour-label layer
    image
  4. Verify that
    • There is no value for the text-keep-upright propery in the JSON Editor
      image
    • The Keep upright checkbox under Text layout properties is clear
      image
    • The center of the map would show:
      image
  5. Click the Keep upright checkbox.
    • The checkbox is now marked
      image
    • But the center of the map would look the same:
      image
  6. Click the Keep upright checkbox again
    • The checkbox is clear, as was when the style was loaded
      image
    • But the text in center of the map would look different that initially:
      image

Style file or style URL:
https://raw.githubusercontent.com/IsraelHikingMap/VectorMap/044e90d16cdab4dcbb8749dd59dd417744c7d6a2/Styles/IHMcontour.json

@pathmapper pathmapper added the bug label Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants