Fix zero size crash #276
Draft
Fix zero size crash #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could be due to headless rendering or Android. Android is very specific in which order surfaces and the rendering context is initialized. |
maxammann
previously approved these changes
Apr 15, 2023
| @@ -25,7 +25,9 @@ impl UpdateState for PanHandler { | |||
| (self.window_position, self.start_window_position) | |||
| { | |||
| let view_proj = view_state.view_projection(); | |||
| let inverted_view_proj = view_proj.invert(); | |||
| let Some(inverted_view_proj) = view_proj.invert() else { | |||
| todo!("what to do here?") | |||
There was a problem hiding this comment.
Basically in this case we would skip the execution of update_state. Apparently it can happen for zero-sized windows. So this should be handled here either with ignoring it or doing a .except(). You usually can not click in a zero-sized window. The except should explain that.
| @@ -22,7 +22,9 @@ impl UpdateState for ZoomHandler { | |||
| self.zoom_delta = None; | |||
|
|
|||
| let view_proj = view_state.view_projection(); | |||
| let inverted_view_proj = view_proj.invert(); | |||
| let Some(inverted_view_proj) = view_proj.invert() else { | |||
| todo!("what to do here?") | |||
| @@ -164,7 +164,8 @@ pub enum Head { | |||
| } | |||
|
|
|||
| pub struct Surface { | |||
| size: WindowSize, | |||
| /// Only render if size is not None | |||
| size: Option<WindowSize>, | |||
There was a problem hiding this comment.
seems reasonable. I think on android this will be initially None.
…y in view state otherwise.
|
@terrorfisch Hi! Are you still interested in pushing this forward? :) I think the conflicts should be rather easily resolvable. If not I can also assist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #274
💻 Examples
Minimize the window or resize it to
y==0. This previously crashed the demo.✔️ PR Todo
todo!s remaining that are not handled yet because I do not understand if these cases can occure at all. It feels like failable projection inversion is only a crutch.WindowSizemember ofSurfacethe way to go to represent a minimized/non-existing render target