Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect imagery display on Firefox #462

Open
willemarcel opened this issue Aug 19, 2021 · 8 comments
Open

Incorrect imagery display on Firefox #462

willemarcel opened this issue Aug 19, 2021 · 8 comments
Assignees
Milestone

Comments

@willemarcel
Copy link

Basic information

After some minutes of use of Mapillary website or using the Mapillary layer on iD editor (osm.org), the images start to be rendered incorrectly.

MapillaryJS version: current
System/Browser: macOS BigSur / Firefox 91.0.1 (64-bit)

Steps to Reproduce Behavior

  1. Go to the Mapillary website, start navigating on the images, or start using the Mapillary layer on osm.org iD editor.

Expected behavior

...

Actual behavior

Screenshot 2021-08-19 at 08 56 52

Screenshot 2021-08-19 at 08 57 32

@oscarlorentzon
Copy link
Member

oscarlorentzon commented Aug 23, 2021

Thanks for reporting.

I cannot reproduce this behavior. Can you share more detailed steps or a screen capture showing how to reproduce? Can you share image IDs for areas where the problem occurs?

@oscarlorentzon
Copy link
Member

@willemarcel Does this problem still occur?

@willemarcel
Copy link
Author

@oscarlorentzon I used mapillary for a long time session today both in mapillary.com and in osm.org and the errors didn't happen.

@willemarcel
Copy link
Author

The problem occurred 2 times again, but every time I try to record my screen, the error didn't happen.

@oscarlorentzon
Copy link
Member

OK, thanks for notifying. It would be great if you could share an image ID/link next time it happens. A video (with Firefox dev tools opened) would also help.

@oscarlorentzon
Copy link
Member

oscarlorentzon commented Nov 24, 2021

@willemarcel Can you make sure to open the developer tools in your browser the next time the error occurs and grab a screenshot of the console output? That would help with debugging.

Also, can you describe in more details the exact steps you take for the error to occur and provide an image ID? I can't seem to reproduce it.

@willemarcel
Copy link
Author

Some images from errors in the console
image

image

This one happened in another session:
image

@oscarlorentzon oscarlorentzon modified the milestones: v4.1.0, v4.2.0 Mar 3, 2022
@oscarlorentzon oscarlorentzon modified the milestones: v4.2.0, v5.0.0 Jul 26, 2022
@JakeSmarter
Copy link

JakeSmarter commented Oct 11, 2023

#462, #480, and “[BUG] Image Zoom Bug in the Web Viewer” may be all connected. For the sake of completeness, I also get the following warning message in the browser console. Yet, I do not think this causes anything.

WebGL warning: texImage: Alpha-premult and y-flip are deprecated for non-DOM-Element uploads. 4 main.d70d902b592f3e7b.js:284:952366

🤔 Call me naive but searching the mapillary-js repo for glFinish or gl.finishand similar has turned up nothing. Maybe mapillary-js is not the place to look into. However, my gut feeling tells me that this is some kind of synchronization issue, be it because of some lack of glFinish() or some other synchronization with the HTML canvas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants