Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-zero border on viewer container #233

Open
oscarlorentzon opened this issue Mar 21, 2017 · 1 comment
Open

Handle non-zero border on viewer container #233

oscarlorentzon opened this issue Mar 21, 2017 · 1 comment

Comments

@oscarlorentzon
Copy link
Member

oscarlorentzon commented Mar 21, 2017

When a non-zero border is used the library does not behave properly because the canvas is shifted and it is not entirely shown because of the fact that offset* values are used. This leads to the following when having top and left borders.

  • Only top left of part photo is shown leading to faulty bouncing among other things.
  • All DOM rendered items that use percentages like TagComponent render in the wrong place.

Relevant reference:
https://developer.mozilla.org/en-US/docs/Web/API/CSS_Object_Model/Determining_the_dimensions_of_elements

Currently the library does not support non-zero border. Maybe a note about this in the docs is enough for now.

@gyllen
Copy link
Member

gyllen commented Mar 21, 2017

I think a note and maybe an assert is enough.

@oscarlorentzon oscarlorentzon added this to the 2.15.0 milestone Dec 6, 2018
@oscarlorentzon oscarlorentzon modified the milestones: 2.15.0, 2.16.0 Jan 25, 2019
@oscarlorentzon oscarlorentzon removed this from the 2.16.0 milestone Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants