Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any love for type hints / mypy / typing? #140

Open
daniel-j-h opened this issue Jun 14, 2021 · 4 comments
Open

Any love for type hints / mypy / typing? #140

daniel-j-h opened this issue Jun 14, 2021 · 4 comments
Assignees

Comments

@daniel-j-h
Copy link
Contributor

Hey folks 馃憢 I'm working on some projects coming with type annotations and I'm using mercantile in there, too.

That's why I'm asking what your thoughts are re. type hints / mypy / typing and shipping them with this library? Should we think about and introduce type hints to mercantile? (and maybe even similar libs in the python geo space - but start with mercantile since it's self-contained and rather small)

Do you have any thoughts, experiences, or blockers?

@geospatial-jeff
Copy link

geospatial-jeff commented Jul 19, 2021

I think type hints are never a bad idea, I'm happy to do a PR to add them.

@Rubix982
Copy link

We can also use something like Pydantic for a bit more complex or complete set of features we can use with both functions and classes.

@sgillies
Copy link
Contributor

No to pydantic. Yes to typing, but that's something I'll take on after I make a roadmap for 2.0. I won't have any time to review PRs until after that @geospatial-jeff, so it would be best to hold off.

@sgillies sgillies self-assigned this Aug 16, 2021
@kylebarron
Copy link

I don't see a 2.0 roadmap, but in case anything has changed on this, I'd also be happy to make a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants