Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build against specific emscripten version #9

Open
ChrisLoer opened this issue Feb 14, 2018 · 0 comments
Open

Build against specific emscripten version #9

ChrisLoer opened this issue Feb 14, 2018 · 0 comments

Comments

@ChrisLoer
Copy link
Contributor

Right now the build script verifies the hash of the emscripten package it downloads, but after it downloads it updates to the latest version of emscripten:

function setup_emsdk {
download_and_extract \
https://s3.amazonaws.com/mozilla-games/emscripten/releases/emsdk-portable.tar.gz \
emsdk-portable.tgz \
4fb6c391effc6a6cd5666abe28a8c7c48a1150f3
emsdk-portable/emsdk update
emsdk-portable/emsdk install latest
emsdk-portable/emsdk activate latest
source emsdk-portable/emsdk_env.sh
}

This is a weird way of guaranteeing the version -- when a new version of emscripten is released and published to https://s3.amazonaws.com/mozilla-games/emscripten/releases/emsdk-portable.tar.gz, the build will break until the hash is updated (at which point it will be using the new version).

Instead, we should point the build to a specific/archived release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant