Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad mapbox-gl dependency version documentation #27

Closed
Danysan1 opened this issue Oct 24, 2021 · 2 comments · Fixed by #31 · May be fixed by #28 or #30
Closed

Bad mapbox-gl dependency version documentation #27

Danysan1 opened this issue Oct 24, 2021 · 2 comments · Fixed by #31 · May be fixed by #28 or #30
Labels

Comments

@Danysan1
Copy link

README.md says that this package "Requires mapbox-gl-js (version 0.32.1 and up).".

package.json however has a dependency to mapbox-gl >=0.32.1 <2.0.0:

  "peerDependencies": {
    "mapbox-gl": ">=0.32.1 <2.0.0"
  },

Since the latest version of mapbox-gl is 2.5.1, this dependency breaks a standard installation and should be documented in the README .

Of course it would be even better if any incompatibility with mapbox-gl >= 2.0.0 was solved and this dependency was changed.
If it can be of any help some days ago I installed mapbox-gl-rtl-text 0.2.3 together with mapbox-gl 2.5.1 using --force in https://www.dsantini.it/etymology and as of now I haven't encountered problems.

@Danysan1 Danysan1 changed the title Bad mapbox-gl dependency documentation Bad mapbox-gl dependency version documentation Oct 24, 2021
@asheemmamoowala asheemmamoowala linked a pull request Oct 25, 2021 that will close this issue
@SnailBones SnailBones added the bug label Nov 8, 2021
@fxi
Copy link

fxi commented Jul 4, 2022

Hello !

Any news on this ? We use the --legacy-peer-deps workaround since a while, but it does not feel right on the long run.

Thanks !

@sven-meyer-wetter-com
Copy link

Any news on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment