Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Offline Font Fallback to Avoid Missing Layers #14854

Open
riastrad opened this issue Jun 5, 2019 · 4 comments
Open

Offline Font Fallback to Avoid Missing Layers #14854

riastrad opened this issue Jun 5, 2019 · 4 comments
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl feature offline

Comments

@riastrad
Copy link
Contributor

riastrad commented Jun 5, 2019

Possibly a duplicate of #7862, but it feels unique enough that I'm opening up a new issue to address it. A user posted to the Android Plugins repo last week complaining that layers where not being applied at runtime when a map didn't have an internet connect: mapbox/mapbox-plugins-android#970

tl;dr the root cause was the fact that the plugin was initializing a SymbolLayer with a text field and this layer was referencing a font family that was not available offline.

I would assert that runtime styling is expected to work offline, and having a runtime layer not populate when offline does not match developer expectations. Adding some sort of fallback for these situations to ensure that the layer is rendered despite the preferred font being unavailable would be a good feature to add.

cc/ @tobrun

@riastrad riastrad added feature Core The cross-platform C++ core, aka mbgl labels Jun 5, 2019
@stale stale bot added the archived Archived because of inactivity label Dec 2, 2019
@stale
Copy link

stale bot commented Dec 2, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Dec 2, 2019
@hrach
Copy link

hrach commented Dec 2, 2019

Please reopen, this is still an issue.

@riastrad riastrad reopened this Dec 2, 2019
@stale stale bot removed the archived Archived because of inactivity label Dec 2, 2019
@386sx
Copy link

386sx commented Apr 6, 2020

Is this issue followed up?

@stale stale bot added the archived Archived because of inactivity label Oct 4, 2020
@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Oct 4, 2020
@riastrad riastrad reopened this Oct 5, 2020
@stale stale bot removed the archived Archived because of inactivity label Oct 5, 2020
@stale stale bot added the archived Archived because of inactivity label Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl feature offline
Projects
None yet
Development

No branches or pull requests

4 participants