Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support symbols for the source._dataType='vector' instead of source.type=='vector' #13138

Open
am2222 opened this issue Apr 5, 2024 · 0 comments

Comments

@am2222
Copy link

am2222 commented Apr 5, 2024

Motivation

So to add support to the custom vector layers I noticed that in the style.js we only support symbol layers for the vector and geojson source types. However I noticed that there is another parameter source._dataType which can be used so it also supports custom source types

Here is the line that checks for the source.type

if (source.type === 'vector' || source.type === 'geojson') {

I guess changing it to check based on source._dataType will allow custom sources to support symbols too

Design Alternatives

it allows to add better support for the vector custom sources.

Implementation

if (source.type === 'vector' || source.type === 'geojson') {

I guess changing it to check based on source._dataType will allow custom sources to support symbols too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant