Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fileprivate identifier on Placemark. #168

Open
Kdan opened this issue Nov 19, 2018 · 1 comment
Open

Fileprivate identifier on Placemark. #168

Kdan opened this issue Nov 19, 2018 · 1 comment

Comments

@Kdan
Copy link

Kdan commented Nov 19, 2018

The identifier field of the Placemark (MBPlacemark) class is currently fileprivate.
This introduces complexity when persisting and matching Placemark objects.
Will this be accessible in the future?

Thanks
/Kewin

@1ec5
Copy link
Contributor

1ec5 commented Jan 23, 2019

We changed the access level from private to fileprivate in #72. I think the reason for making them private was that the numeric portion of each identifier isn’t guaranteed to be stable; it’s somewhat of an implementation detail. If we expose the identifier property publicly, there might have to be a caveat about the values being arbitrary and potentially unsuitable for long-term storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants