Expected fields do not always appear in the MBGeocodedPlacemark

[johnnewman]

Using v0.10.0.

If I reverse geocode a point in the water of the San Francisco Bay, "California" does not appear as an administrativeRegion on the MBGeocodedPlacemark. If I print the addressDictionary of the placemark, I see that the name is California, but it is not placed under the state key.

Sample code:

CLLocationCoordinate2D coordinate = CLLocationCoordinate2DMake(37.763778227711242, -122.32790567148118);
MBGeocoder *geocoder = [[MBGeocoder alloc] initWithAccessToken:<token>];
MBReverseGeocodeOptions *options = [[MBReverseGeocodeOptions alloc] initWithCoordinate:coordinate];
[geocoder geocodeWithOptions:options completionHandler:^(NSArray<MBGeocodedPlacemark *> * _Nullable placemarks, NSString * _Nullable attribution, NSError * _Nullable error) {
        
    NSLog(@"%@", [placemarks[0] addressDictionary]);
      
}];

Output:

{
    ISOCountryCode = US;
    country = "United States";
    formattedAddressLines =     (
        "United States"
    );
    name = California;
}

This makes it challenging to properly format and display reverse geocode data that is powered by a dynamic location at run time. If I reverse geocode a location that has a street address, it likely has a state field.

Below is the addressDictionary of a reverse geocode coordinate in downtown San Francisco. The state is now there. (37.794291209161685, -122.412848997168)

{
    ISOCountryCode = US;
    city = "San Francisco";
    country = "United States";
    formattedAddressLines =     (
        "1187 Washington Street",
        "San Francisco",
        "California 94108",
        "United States"
    );
    name = "Washington Street";
    postalCode = 94108;
    state = California;
    street = "Washington Street";
    subAdministrativeArea = "San Francisco";
    subLocality = "Nob Hill";
    subThoroughfare = 1187;
    thoroughfare = "Washington Street";
}

[1ec5]

Specifically, this is happening because the placemark is itself a region, but Placemark is looking for containing placemarks that are regions:

MapboxGeocoder.swift/MapboxGeocoder/MBPlacemark.swift

Lines 537 to 539 in 4365b4c

	if let regionName = administrativeRegion?.name {
	postalAddress.state = regionName
	}

MapboxGeocoder.swift/MapboxGeocoder/MBPlacemark.swift

Lines 306 to 308 in 4365b4c

	@objc open var administrativeRegion: Placemark? {
	return superiorPlacemarks?.lazy.filter { $0.scope == .region }.last
	}

The same behavior applies to all the other “Accessing Containing Placemarks” properties, such as postalCode. The fix would be to conditionally fall back to self if self has a matching scope.