Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the tools' preview UX in general #357

Closed
20 tasks done
maoschanz opened this issue Apr 5, 2021 · 0 comments
Closed
20 tasks done

improve the tools' preview UX in general #357

maoschanz opened this issue Apr 5, 2021 · 0 comments
Assignees
Labels
accessibility bugs or features addressing needs of people with a disability or impairment enhancement ideas to improve existing features tools bugs or suggestions related to tools
Milestone

Comments

@maoschanz
Copy link
Owner

maoschanz commented Apr 5, 2021

Use case

for all these things:

  • inserting text
  • drawing free shape or polygon
  • 2-steps curves
  • rotating
  • skew
  • ...?

it's not clear that the preview is indeed just a preview

Suggested solution

  • ensure there is always an accurate edition status (get_editing_tips)
  • consistently apply previews by default instead of canceling them when the tool changes
  • [ ] consistently apply previews by default instead of whatever happens when the tab changes (see issues Ghost selection when working with several tabs #580 )
  • redesign the text tool:
    • [ ] [optional] entry with custom css directly on the layout?? The point of a GtkLayout is to put widgets on it #4
    • area around that text (with margin and dashed outline) to move it
      • manage the pointer on hover 😔
      • keep a consistent margin regardless of the zoom level 😔
    • clicking outside this outline confirms the insertion
    • auto-refresh the preview when options changes
    • accurate edition status, again, explaining what to do, where to click, etc.
  • split "what needs to happen tool-wide when options change" away from the get_editing_tips tool method, so the preview always has accurate options
    • implement this split for all tools
    • include the tool thickness
    • include the tool color(s)
    • stop doing any update to options' values in on_press_on_area

Possible drawbacks

too many editing status would defeat their own point #567

likely not possible everywhere (edit: yes #583)

i should have a better framework to track what the pointer is hovering, otherwise it'll always look awful

@maoschanz maoschanz added enhancement ideas to improve existing features tools bugs or suggestions related to tools accessibility bugs or features addressing needs of people with a disability or impairment labels Apr 5, 2021
@maoschanz maoschanz added this to the 1.0.0 milestone Jun 24, 2021
@maoschanz maoschanz pinned this issue Dec 4, 2021
@maoschanz maoschanz modified the milestones: 1.0.0, 1.2.0 Dec 6, 2021
@maoschanz maoschanz self-assigned this Mar 30, 2022
@maoschanz maoschanz changed the title Make it clearer when something is a preview improve the tools' preview UX in general Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bugs or features addressing needs of people with a disability or impairment enhancement ideas to improve existing features tools bugs or suggestions related to tools
Projects
None yet
Development

No branches or pull requests

1 participant