Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better errors #203

Open
goldylucks opened this issue Jul 6, 2019 · 1 comment
Open

Better errors #203

goldylucks opened this issue Jul 6, 2019 · 1 comment

Comments

@goldylucks
Copy link

Thanks for a FANTASTIC library, you guys ROCK!

So I'm using this function:
return orderByDistance({ latitude, longitude }, restaurants)

and I get this error:

image

Now I have to go down the rabbit hole of geolib's internals to understand what is causing the error.

Would be a better DX to see something like WARNING - latitude is missing for item 5 on the list

I can submit a PR with some guidance :)

@manuelbieh
Copy link
Owner

Thank you! That’s a great idea! Feel free to do so!

goldylucks added a commit to goldylucks/geolib that referenced this issue Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants