Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in output from multi-domain fitting. #19161

Merged
merged 2 commits into from Mar 16, 2017
Merged

Conversation

mantid-roman
Copy link
Contributor

@mantid-roman mantid-roman commented Mar 16, 2017

Reverting recent changes to IFunction::asString() method that don't output values of tied or fixed parameters. Outputs from a multi-domain fit are calculated by copies of member functions of a MultiDomainFunction. Tied parameters were not set properly.

To test:

Run the script from the issue description.

Fixes #19115.

This probably needs to be in the release notes.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@mantid-roman mantid-roman added Component: Fitting Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) labels Mar 16, 2017
@mantid-roman mantid-roman added this to the Release 3.10 milestone Mar 16, 2017
@AnthonyLim23 AnthonyLim23 self-assigned this Mar 16, 2017
@AnthonyLim23 AnthonyLim23 added the Patch Candidate Urgent issues that must be included in a patch following a release label Mar 16, 2017
@AnthonyLim23
Copy link
Contributor

Behaves as expected. :shipit: once Jenkins is done

@martyngigg martyngigg self-assigned this Mar 16, 2017
@martyngigg martyngigg merged commit 29e3bb8 into master Mar 16, 2017
@martyngigg martyngigg deleted the 19115_muon_multi_fit_bug branch March 16, 2017 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Patch Candidate Urgent issues that must be included in a patch following a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot does not match the function
3 participants