Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reduction for osiris diffspec #19022

Merged
merged 1 commit into from Mar 1, 2017
Merged

Add reduction for osiris diffspec #19022

merged 1 commit into from Mar 1, 2017

Conversation

louisemccann
Copy link
Contributor

@louisemccann louisemccann commented Feb 28, 2017 •
edited

Added a reduction step for OSIRIS diffspec when Run is clicked

To test:

Interfaces>Indirect>Diffraction
Set instrument to OSIRIS, mode to diffspec
Input: 89813
Calibration: osiris_041_RES10.cal
Inputs can be found in the unit tests \Build\ExternalData\Testing\Data\UnitTest

No need for vanadium

Fixes #19021 .

Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@louisemccann louisemccann added Indirect/Inelastic Issues and pull requests related to indirect or inelastic Patch Candidate Urgent issues that must be included in a patch following a release High Priority An issue or pull request that if not addressed is severe enough to postponse a release. labels Feb 28, 2017
@louisemccann louisemccann added this to the Release 3.9.1 milestone Feb 28, 2017
@martyngigg martyngigg self-assigned this Mar 1, 2017
martyngigg
martyngigg approved these changes Mar 1, 2017
View reviewed changes
Copy link
Member

@martyngigg martyngigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restores functionality that was accidentally removed in fixing a previous bug found in #18857.

I checked both modes on OSIRIS and each run the reduction and give the same result as 3.9.0.

:shipit:

@martyngigg
Copy link
Member

@mantidproject/gatekeepers The doc test failure is unrelated and one of the current crop of unstable tests.

Can we get this merged ASAP, please?

@SimonHeybrock SimonHeybrock merged commit 1fb4431 into master Mar 1, 2017
@SimonHeybrock SimonHeybrock deleted the 19021_osiris_diffspec branch March 1, 2017 08:35
@SimonHeybrock
Copy link
Contributor

@martyngigg Ah, was this supposed to be merged into master?

@martyngigg
Copy link
Member

@SimonHeybrock Yes that's okay. For the patch we generally cherry-pick the commits from master.

martyngigg pushed a commit that referenced this pull request Mar 1, 2017
@louisemccann @martyngigg
Cherry-pick pull request #19022
a948b43 
Refs #19021 add reduction for osiris diffspec

(cherry picked from commit 56001ff)

Add patch release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martyngigg martyngigg martyngigg approved these changes

Assignees

@martyngigg martyngigg

Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Indirect/Inelastic Issues and pull requests related to indirect or inelastic Patch Candidate Urgent issues that must be included in a patch following a release
Projects
None yet
Milestone
Release 3.9.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louisemccann @martyngigg @SimonHeybrock