Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bank43 to TOPAZ IDF this run cycle #18995

Merged
merged 1 commit into from Feb 24, 2017
Merged

Conversation

VickieLynch
Copy link
Contributor

Description of work.
Added bank43 to TOPAZ IDF for runs starting Feb 24, 2017.

To test:

Load(Filename='TOPAZ_22405_event.nxs', OutputWorkspace='TOPAZ_22405_event')
LoadEmptyInstrument(Filename='TOPAZ_Definition_2016-07-14.xml', OutputWorkspace='2016')
LoadEmptyInstrument(Filename='TOPAZ_Definition_2017-02-24.xml', OutputWorkspace='2017')

Compare 2016 and 2017 with Show Instrument. Check that TOPAZ_22405 has 2016 instrument.

Fixes #18994

Does not need to be in the release notes.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@VickieLynch VickieLynch added Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal Patch Candidate Urgent issues that must be included in a patch following a release labels Feb 24, 2017
@VickieLynch VickieLynch added this to the Release 3.10 milestone Feb 24, 2017
@AndreiSavici
Copy link
Member

:shipit: Low impact, so it would be easy to merge into 3.9.1

@martyngigg
Copy link
Member

That makes sense. Users will see the file anyway with the automatic IDF updates.

martyngigg added a commit that referenced this pull request Feb 24, 2017
Refs #18994 new bank this cycle

(cherry picked from commit 2e89f73)

Add patch release note
@peterfpeterson peterfpeterson merged commit a75a4b3 into master Feb 24, 2017
@peterfpeterson peterfpeterson deleted the 18994_bank43_topaz_idf branch February 24, 2017 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction Patch Candidate Urgent issues that must be included in a patch following a release Single Crystal Issues and pull requests related to single crystal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants