Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading dead time data in Muon interface #18972

Merged
merged 5 commits into from Feb 23, 2017

Conversation

AnthonyLim23
Copy link
Contributor

The cache in muon analysis is now cleared when the data is updated (change to the dead time correction, first good data and start time).

To test:

In muon analysis make sure that when the screen is generated "None" is selected for the dead time correction. Load some data and then change the dead time correction and the plot should be updated.
Fixes #18950 .


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@AnthonyLim23 AnthonyLim23 added Muon Issues and pull requests related to muons Patch Candidate Urgent issues that must be included in a patch following a release labels Feb 23, 2017
@AnthonyLim23 AnthonyLim23 added this to the Release 3.10 milestone Feb 23, 2017
@KarlPalmen KarlPalmen self-assigned this Feb 23, 2017
@KarlPalmen
Copy link
Contributor

I noticed a change when the dead-time widget was changed from None to From Data File for a HIFI file I have. :shipit:

@peterfpeterson peterfpeterson merged commit f8dac2f into master Feb 23, 2017
@peterfpeterson peterfpeterson deleted the 18950_ReadingDeadTimeData branch February 23, 2017 15:43
@martyngigg martyngigg self-assigned this Feb 23, 2017
@martyngigg martyngigg changed the title Reading dead time data Fix reading dead time data in Muon interface Feb 23, 2017
martyngigg pushed a commit that referenced this pull request Feb 23, 2017
refs #18950 Forced deadTime data to be read during cache

(cherry picked from commit a2b5275)

refs #18950 Empty cache for deadTimes, firstGoodData and startTime

(cherry picked from commit 67ea45d)

refs #18950 Removed indent in DataLoader

(cherry picked from commit 7efdc11)

refs #18950 Renamed emptyCache to clearCache

(cherry picked from commit abd3fe0)

refs #18950 clang format

(cherry picked from commit 786d435)

Add patch release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Muon Issues and pull requests related to muons Patch Candidate Urgent issues that must be included in a patch following a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants