Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in MonitorDlg #18955

Merged
merged 1 commit into from Feb 23, 2017
Merged

Conversation

gemmaguest
Copy link
Member

This PR avoids a potential crash when clicking the Details button to open the monitor dialog. It does not solve the root cause of the problem (an algorithm pointer being null) but stops mantid crashing if a null pointer is found.

To test:

The crash is intermittent and is not easily reproducible. The problem has been seen frequently by offspec users and we have managed to reproduce it under the debugger on their machine. They are testing a dev version with the same fix as this PR and so far have not seen the crash again.

Fixes #18951 .


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@gemmaguest gemmaguest added Component: GUI Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Patch Candidate Urgent issues that must be included in a patch following a release labels Feb 21, 2017
@gemmaguest gemmaguest added this to the Release 3.10 milestone Feb 21, 2017
@martyngigg martyngigg self-assigned this Feb 22, 2017
Copy link
Member

@martyngigg martyngigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a preventative check for a null pointer. This is actually required as the AlgorithmManager can in fact return a null pointer if the algorithm is not found it's managed list which could happen if the algorithm being queried has been knocked off the list.

:shipit:

@martyngigg martyngigg added the High Priority An issue or pull request that if not addressed is severe enough to postponse a release. label Feb 22, 2017
@peterfpeterson peterfpeterson merged commit bb09b60 into master Feb 23, 2017
@peterfpeterson peterfpeterson deleted the 18951_fix_crash_in_MonitorDlg branch February 23, 2017 15:43
martyngigg added a commit that referenced this pull request Feb 23, 2017
Re #18951 Add check for null algorithm pointer

(cherry picked from commit f75d92b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Patch Candidate Urgent issues that must be included in a patch following a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monitor dialog crashes when clicking Details button
3 participants