Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for if nonorthogonal axes should be displayed #18833

Merged
merged 1 commit into from Feb 14, 2017

Conversation

lottiegreenwood
Copy link

Fixes #18832

To test, open a workspace with HKL axes. Change the dimensions shown and ensure the axes remain consistent. Switch back and forth between nonorthogonal and orthogonal modes and also check this.

@lottiegreenwood lottiegreenwood added Diffraction Issues and pull requests related to diffraction Single Crystal Issues and pull requests related to single crystal Vates labels Feb 13, 2017
@lottiegreenwood lottiegreenwood added the Patch Candidate Urgent issues that must be included in a patch following a release label Feb 14, 2017
@AntonPiccardoSelg
Copy link
Contributor

@lottiegreenwood Which data set did you use?

The change makes sense and I saw the issue on your screen, but I am having trouble reproducing it. It works quite well with and without the fix. Maybe it is more visible with some data sets.

@AntonPiccardoSelg
Copy link
Contributor

The changes make sense and I was able to reproduce the bug without the fix. With the fix the dimensions are displayed correctly.
Please :shipit:

@martyngigg martyngigg changed the title Added check for if nonorthogonal axes should be displayed Re #18832 Added check for if nonorthogonal axes should be displayed Feb 14, 2017
@martyngigg martyngigg added this to the Release 3.10 milestone Feb 14, 2017
@martyngigg martyngigg self-assigned this Feb 14, 2017
@martyngigg martyngigg merged commit e50a985 into master Feb 14, 2017
@martyngigg martyngigg deleted the 18832_incorrect_sliceviewer_axis branch February 14, 2017 16:03
martyngigg added a commit that referenced this pull request Feb 23, 2017
Added check for if nonorthogonal axes should be displayed Re #18832

(cherry picked from commit 0d1ce7c)

Added patch release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction Patch Candidate Urgent issues that must be included in a patch following a release Single Crystal Issues and pull requests related to single crystal Vates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants