Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add live data address for mandi #18777

Merged
merged 2 commits into from Feb 23, 2017
Merged

Add live data address for mandi #18777

merged 2 commits into from Feb 23, 2017

Conversation

VickieLynch
Copy link
Contributor

@VickieLynch VickieLynch commented Feb 9, 2017 •
edited

Description of work. Live data address added for mandi

To test:
StartLiveListener with this Python Script in the Post Processing on mandi2 while Klemen Vodopivec is replaying data. Use temp as Accumulation Workspace and live as Output Workspace.

AddSampleLog(Workspace=input, LogName='chi', LogText='130.0', LogType='Number')
SetGoniometer(Workspace=input,Axis0="omega,0,1,0,1",Axis1="chi,0,0,1,1",Axis2="phi,0,1,0,1")
live=ConvertToMD(InputWorkspace=input, QDimensions='Q3D', dEAnalysisMode='Elastic', LorentzCorrection=True, MinValues='-10,-10,-10', MaxValues='10,10,10', SplitInto='2', SplitThreshold=50, MaxRecursionDepth=11)
FindPeaksMD(InputWorkspace=live, PeakDistanceThreshold=0.51381818181818184, MaxPeaks=200, OutputWorkspace='peaks_ws')[

Fixes #18770

Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@VickieLynch VickieLynch added Diffraction Issues and pull requests related to diffraction Component: Live Data Single Crystal Issues and pull requests related to single crystal labels Feb 9, 2017
@VickieLynch VickieLynch added this to the Release 3.10 milestone Feb 9, 2017
@peterfpeterson peterfpeterson self-assigned this Feb 23, 2017
@peterfpeterson
Copy link
Member

The change looks correct :shipit:

@martyngigg martyngigg self-assigned this Feb 23, 2017
@martyngigg martyngigg merged commit 3acb069 into master Feb 23, 2017
@martyngigg martyngigg deleted the 18770_liveMaNDi branch February 23, 2017 14:51
@peterfpeterson peterfpeterson added the Patch Candidate Urgent issues that must be included in a patch following a release label Feb 23, 2017
martyngigg added a commit that referenced this pull request Feb 23, 2017
@martyngigg
Cherry pick pull request #18777
f5d47cc 
Refs #18770 add live data address for mandi

(cherry picked from commit 4876d3c)

Add release patch note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@peterfpeterson peterfpeterson

@martyngigg martyngigg

Labels
Diffraction Issues and pull requests related to diffraction Patch Candidate Urgent issues that must be included in a patch following a release Single Crystal Issues and pull requests related to single crystal
Projects
None yet
Milestone
Release 3.9.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@VickieLynch @peterfpeterson @martyngigg