Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indirect Diffraction interface refactor #37231

Open
3 tasks
Tracked by #37229
robertapplin opened this issue Apr 26, 2024 · 0 comments
Open
3 tasks
Tracked by #37229

Indirect Diffraction interface refactor #37231

robertapplin opened this issue Apr 26, 2024 · 0 comments
Labels
Epic Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.

Comments

@robertapplin
Copy link
Contributor

robertapplin commented Apr 26, 2024

Description

The code for the Indirect Diffraction interface could do with some refactoring to make it easier to test certain areas of the code, and to ensure that it is easier to maintain and extend in the future. The current code for the interface is all in the DiffractionReduction file, and it would be good to separate this out so the Qt framework is isolated from most of the logic in the code. We also want to reduce the reliance on the IndirectTab class which it inherits from.

This issue is an overarching issue which will be used to keep track of the refactoring for the Indirect Diffraction interface that is required for the code to be in good shape.

Plan

  • MVP for Indirect Diffraction interface #37232
  • The AlgorithmRunner class should be used instead of the BatchAlgorithmRunner as it means we can avoid Qt connections in our presenter.
  • The Diffraction interface should also be made independent from the InelasticTab class as much as possible.
@robertapplin robertapplin added ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Indirect/Inelastic Issues and pull requests related to indirect or inelastic Maintenance Unassigned issues to be addressed in the next maintenance period. Epic labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Status: No status
Development

No branches or pull requests

1 participant