Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F(Q) Fit warnings after adding data multiple times #37185

Closed
robertapplin opened this issue Apr 18, 2024 · 0 comments · Fixed by #37223
Closed

F(Q) Fit warnings after adding data multiple times #37185

robertapplin opened this issue Apr 18, 2024 · 0 comments · Fixed by #37223
Assignees
@adriazalvarez
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS
Milestone
Release 6.10

Comments

@robertapplin
Copy link
Contributor

Original reporter: Waruna

Describe the bug
The F(Q) Fit tab can sometimes display confusing warning messages when adding data twice.

To Reproduce

  1. Open Inelastic->QENS Fitting
  2. Go to F(Q) fit tab
  3. click Add Workspace
  4. browse the file below
    irs26176_graphite002_red_Conv_seq_2L_0-50__Result.zip
  5. click Add
  6. close the Data Selection UI
  7. repeat again from step 3

This will eventually happen:
image

Expected behavior
This warning should not be displayed. There must be some logic problem going on in F(Q) Fit interface code.

Screenshots
Waruna was also able to unreliably get this warning:
image

Platform/Version (please complete the following information):

  • OS: Found on Windows
@robertapplin robertapplin added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS labels Apr 18, 2024
@robertapplin robertapplin added this to the Release 6.10 milestone Apr 18, 2024
@robertapplin robertapplin mentioned this issue Apr 18, 2024
Merged
@adriazalvarez adriazalvarez mentioned this issue Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adriazalvarez adriazalvarez

Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS
Projects
ISIS Spectroscopy
Status: Done v6.10
Milestone
Release 6.10
Development

Successfully merging a pull request may close this issue.

Prevent warnings when adding data from dialogs in QENS fitting interface mantidproject/mantid
2 participants
@robertapplin @adriazalvarez