Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithms that Override Process Groups Do Not Report Errors When Called From Algorithm Dialog #37212

Open
cailafinn opened this issue Apr 24, 2024 · 0 comments
Assignees
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS

Comments

@cailafinn
Copy link
Contributor

Describe the bug
When an algorithm is called with a group workspace it will make a call to processGroups(). For most algorithms, this will just run the algorithm on every individual workspace in the group.

However, if you want to actually process groups specially, this method is overridden. This seems to cause a bug where throwing an error results in nothing being sent to the message log. This can be very confusing as you only get the "AlgName Started" message and nothing more.

Strangely, this only occurs when the algorithm is called from the dialog. Calling the algorithm in a script causes it to act as you would expect.

To Reproduce

  1. Load/Create a group workspace
  2. Open the SaveNexusESS dialog (it doesn't have to be this, it's just a convenient example).
  3. Provide the group workspace as an input
  4. Run the algorithm.
  5. Nothing will happen.

Expected behavior
Any errors produced should be seen in the messages log.

Platform/Version (please complete the following information):

  • OS: Seen on macOS and Windows, assume all.
  • Mantid Version: At least as early as 6.7
@cailafinn cailafinn added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels Apr 24, 2024
@jhaigh0 jhaigh0 self-assigned this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Framework Issues and pull requests related to components in the Framework ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
Status: No status
Development

No branches or pull requests

2 participants