Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write tests for elwin presenter #34928

Closed
Harrietbrown opened this issue Jan 13, 2023 · 0 comments · Fixed by #37210
Closed

Write tests for elwin presenter #34928

Harrietbrown opened this issue Jan 13, 2023 · 0 comments · Fixed by #37210
Assignees
@adriazalvarez
Labels
ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.

Comments

@Harrietbrown
Copy link
Contributor

Harrietbrown commented Jan 13, 2023 •
edited by robertapplin

The presenter for elwin should have tests written for them coving essencial components.

Acceptance Criteria

  • The public member functions in the Elwin presenter each have a test in an Elwin presenter test suite
@Harrietbrown Harrietbrown added Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS labels Jan 13, 2023
@AnthonyLim23 AnthonyLim23 added this to the Release 6.7 milestone Apr 6, 2023
@sf1919 sf1919 modified the milestones: Release 6.7, Release 6.8 May 30, 2023
@sf1919 sf1919 modified the milestones: Release 6.8, Release 6.9 Sep 18, 2023
@robertapplin robertapplin removed this from the Release 6.9 milestone Nov 16, 2023
@adriazalvarez adriazalvarez self-assigned this Apr 4, 2024
@adriazalvarez adriazalvarez mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adriazalvarez adriazalvarez

Labels
ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
ISIS Spectroscopy
Status: Done v6.10
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for the presenter of elwin interface mantidproject/mantid
5 participants
@AnthonyLim23 @robertapplin @Harrietbrown @sf1919 @adriazalvarez