Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tie Heights option for ConvFit #37200

Open
robertapplin opened this issue Apr 23, 2024 · 0 comments
Open

Tie Heights option for ConvFit #37200

robertapplin opened this issue Apr 23, 2024 · 0 comments
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS

Comments

@robertapplin
Copy link
Contributor

Requested by: Spencer

Description:
Spencer has requested that we add an option to ConvFit to make it easier to tie the Heights of the two lorentzians when 2 lorentzians are selected. There is a very similar option in IqtFit which is used called "Tie Intensities", except it ties different parameters.

Seeing as there is already a precident for this sort of thing, I think it could be a worthwhile addition.

Maybe the code behind this option can be made more generic so it is easier to add similar options in the future if required.

Acceptance Criteria

  • An option to "Tie Heights" exists in the ConvFit tab of QENS Fitting
  • The code is generic, maybe reusing code used for the "Tie Intensities" option in IqtFit
@robertapplin robertapplin added ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Indirect/Inelastic Issues and pull requests related to indirect or inelastic labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS
Projects
Status: No status
Development

No branches or pull requests

1 participant