Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Function Browsers going out of sync #37228

Conversation

robertapplin
Copy link
Contributor

@robertapplin robertapplin commented Apr 26, 2024

Description of work

This PR fixes a bug where the Full FunctionBrowser and Template FunctionBrowser on the QENS Fitting interface could go out of sync when all functions are removed from either one, before switching to a different view.

Fixes #37199

To test:

Open Inelastic->QENS Fitting
Go to IqtFit tab
Select Stretched Exp as Fit type
Tick See full function, it should have the stretched exp
Untick See full function
Select None as Fit type
Tick See full function, it should be empty.

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS labels Apr 26, 2024
@robertapplin robertapplin added this to the Release 6.10 milestone Apr 26, 2024
@robertapplin robertapplin marked this pull request as ready for review April 26, 2024 13:26
@warunawickramasingha
Copy link
Contributor

I was following these instructions as given on Windows.

  1. Open Inelastic->QENS Fitting

  2. Go to IqtFit tab

  3. Select Stretched Exp as Fit type -->I can see below - seems ok
    image

  4. Tick See full function, it should have the stretched exp --> the browser get cleared - Is that ok?
    image

@robertapplin
Copy link
Contributor Author

I was following these instructions as given on Windows...

Oh sorry, I forgot to say you need to load data before adding the fit function

irs26176_graphite002_iqt.zip

That behaviour without the data loaded is expected

Copy link
Contributor

@warunawickramasingha warunawickramasingha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing the data file to load. Happy to approve as this is working as expected after loading the data file!

@SilkeSchomann SilkeSchomann merged commit b7393b2 into mantidproject:main May 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Full function and template function can go out of sync
3 participants