Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyChop - incorrect phase offset for disk on MERLIN #37045

Closed
mducle opened this issue Mar 19, 2024 · 2 comments · Fixed by #37188
Closed

PyChop - incorrect phase offset for disk on MERLIN #37045

mducle opened this issue Mar 19, 2024 · 2 comments · Fixed by #37188
Assignees
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Excitations/Vesuvio Issue and pull requests managed by the Excitiations/Vesuvio subteam at ISIS Reported By User Issues that were found or highlighted by a user/scientist

Comments

@mducle
Copy link
Member

mducle commented Mar 19, 2024

Original reporter: ISIS / T. Williams

Describe the bug
A few years ago (~2021?), the disk chopper controller on MERLIN was replaced / upgraded. Unfortunately this lead to an offset (of 4500 us) in the time-delay set by Mantid compared to what PyChop believes the time delay (chopper phase) is. Although it is a feature not often used, PyChop allows users to set the delay time of the disk chopper on MERLIN to govern which "reps" (incident energies) are allow to become incident on the sample. Because of the offset, if users set the delay time which PyChop suggests, they would be setting the wrong chopper phase and may not end up measuring anything and so lose time during experiments.

To Reproduce

  1. Open PyChop and select Merlin as the instrument. Put 50 in the Ei text box. Click Calculate and Plot.
  2. Click on the Time-Distance tab near the top.
  3. Go to the Options menu and select Instrument Scientist Mode - you should see an addition box Disk chopper phase delay time added to the GUI.
  4. Change the value 1500 in this box to 3000 and see that the first two "reps" (at 133 and 50meV) are now blocked.

In fact in real life, a phase delay time of 3000 set in the IBEX control actually corresponds to 7500 us in PyChop terms so many more reps will be blocked and it's likely that the user will not be measuring anything.

Expected behavior
The phase input in PyChop matches the phase set by the IBEX controller program.

Screenshots
N/A

Platform/Version (please complete the following information):
All, since Mantid 3.x

Additional context

@mducle mducle added the Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) label Mar 19, 2024
@sf1919 sf1919 added ISIS Team: Excitations/Vesuvio Issue and pull requests managed by the Excitiations/Vesuvio subteam at ISIS Reported By User Issues that were found or highlighted by a user/scientist labels Mar 21, 2024
@SilkeSchomann
Copy link
Contributor

@mducle Does this mean we could just subtract the offset of 4500 for chop2Phase in

chop2Phase = phase = chop2Phase if hasattr(chop2Phase, "__len__") else [chop2Phase]
for Merlin? Does that also apply to the default of 1500 when the user does not select Instrument Scientist Mode?

@mducle
Copy link
Member Author

mducle commented Apr 3, 2024

@SilkeSchomann yes, I think we can just subtract the "experimental" offset of 4500 in chop2Phase for Merlin.

It might be good to make this a parameter read from the yaml file.

The actual default experimental value in the IBEX program for MERLIN is 12500 us (which corresponds to 17000 us in current PyChop terms [without the offset]). I think that for consistency for user this value should be used instead of the current 1500 value if that's ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Excitations/Vesuvio Issue and pull requests managed by the Excitiations/Vesuvio subteam at ISIS Reported By User Issues that were found or highlighted by a user/scientist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants