Prevent warnings when adding data from dialogs in QENS fitting interface #37223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This PR fixes a warning that can appear whenever data is being loaded from dialogs in all tabs of QENS fitting interface. Even if the data is taking a long time to load, it is still possible to click on the
Add
button of the dialog window, which will cause the interface to try to act on the data while is being loaded on the ADS, thus creating warnings or crashes.The solution I have adopted to fix this undesired behaviour from the dialogs is to emit a signal from the
Data Selector
widget when it autoloads the data. This signal can then by received by the dialog interface to disable theAdd
button (and change its text) until the loading of the data is finished.However, there are still problems with the dialogs:
A more fitting solution would be to implement a manager class for the loading algorithm in a different thread with which we can communicate (#37184). There are plans to implement that solution for Mantid 6.11. But I still think emitting a signal from the selector widget when it is auto-loading may be a good inclusion. And disabling the button helps the users understand what is happening with the data.
Summary of work
Fixes #37185 .
Further detail of work
To test:
Add
button until the data is loaded.Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.