New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Muon Spin Diffusion fit function #37194
Draft
robertapplin
wants to merge
18
commits into
mantidproject:main
Choose a base branch
from
robertapplin:37176-muon-spin-diffusion-fit-function
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Muon Spin Diffusion fit function #37194
robertapplin
wants to merge
18
commits into
mantidproject:main
from
robertapplin:37176-muon-spin-diffusion-fit-function
+173
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertapplin
added
Muon
Issues and pull requests related to muons
ISIS Team: Spectroscopy
Issue and pull requests managed by the Spectroscopy subteam at ISIS
labels
Apr 22, 2024
robertapplin
force-pushed
the
37176-muon-spin-diffusion-fit-function
branch
2 times, most recently
from
May 1, 2024 15:01
488b612
to
0ba127d
Compare
robertapplin
force-pushed
the
37176-muon-spin-diffusion-fit-function
branch
from
May 2, 2024 16:20
0ba127d
to
f6d85de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ISIS Team: Spectroscopy
Issue and pull requests managed by the Spectroscopy subteam at ISIS
Muon
Issues and pull requests related to muons
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Summary of work
Fixes #37176
Further detail of work
To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.