Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrupted recovery file will stop workbench from opening #37175

Closed
jhaigh0 opened this issue Apr 16, 2024 · 0 comments · Fixed by #37178
Closed

Corrupted recovery file will stop workbench from opening #37175

jhaigh0 opened this issue Apr 16, 2024 · 0 comments · Fixed by #37178
Assignees
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS

Comments

@jhaigh0
Copy link
Contributor

jhaigh0 commented Apr 16, 2024

When updating the project recovery code (#36859) I changed the find_number_of_workspaces_in_directory method to read in the .recfile which is a json dump of things like the open plots.

If this file is corrupted somehow (maybe mantid is closed / crashses while the json write is happening?) there will be an uncaught exception when opening workbench.

To Reproduce
I somehow got this to happen, I thought it was related to #37168 but I think in that cases no file is written.
The best thing would be to open workbench and open a few interfaces and plots, then wait for recovery to run.
Then go and find the .recfile (on windows recovery data is in
C\Users\<user_name>\AppData\Roaming\mantidproject\mantid\workbench-recovery) and delete something from the end of the json string.

Expected behavior
The checkpoint should fail and not be an option in the checkpoint selection widget.

Platform/Version (please complete the following information):

  • OS: Windows
  • OS Version:
  • Mantid Version Main
@jhaigh0 jhaigh0 added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels Apr 16, 2024
@jhaigh0 jhaigh0 self-assigned this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant