Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend SaveISISReflectometryORSO to output as ORSO Nexus file #37162

Closed
rbauststfc opened this issue Apr 12, 2024 · 0 comments · Fixed by #37289
Closed

Extend SaveISISReflectometryORSO to output as ORSO Nexus file #37162

rbauststfc opened this issue Apr 12, 2024 · 0 comments · Fixed by #37289
Assignees
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Reflectometry Issues and pull requests related to reflectometry
Milestone

Comments

@rbauststfc
Copy link
Contributor

rbauststfc commented Apr 12, 2024

The orsopy library (version 1.2.0, which we're currently using) now supports outputting to Nexus format using the following code:

from orsopy.fileio.orso import save_nexus
save_nexus(datasets={list of datasets}, fname={FILEPATH.orb})

Note the saved file has extension .orb.

It would be good to extend the SaveISISReflectometryORSO algorithm to provide a choice between outputting in either the Ascii or the Nexus format. We should also add this as an option to the Reflectometry GUI.

Note that in the Reflectometry GUI the save tab is currently labelled Save Ascii. We should remove the Ascii part to avoid confusion. Where reasonable in the code, we should also consider appropriate re-naming of classes, etc.

@rbauststfc rbauststfc added Reflectometry Issues and pull requests related to reflectometry ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS labels Apr 12, 2024
@rbauststfc rbauststfc added this to the Release 6.10 milestone Apr 12, 2024
@rbauststfc rbauststfc self-assigned this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Reflectometry Issues and pull requests related to reflectometry
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant