Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickBayes algorithm improvements #37153

Open
6 tasks
robertapplin opened this issue Apr 10, 2024 · 0 comments
Open
6 tasks

QuickBayes algorithm improvements #37153

robertapplin opened this issue Apr 10, 2024 · 0 comments
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS

Comments

@robertapplin
Copy link
Contributor

Description
There are a couple of improvements we need to make to the BayesQuasi2 and BayesStretch2 algorithms which use the quickBayes package, so that they have similar features to the BayesQuasi and BayesStretch algorithms.

  • linear = sloping for v2 algorithms
  • Sequential Fit option in Stretch is not possible. Its no longer a sequential fit by the sounds, because its done in parallel? Need to check
  • Fixed width missing feature
  • Maybe different name for output workspaces for quickbayes to make it easier to test
  • One little bug - quickbayes uses Gamma instead of FWHM so plotting from gui doesn't work.

Other improvements before we can do a switch:

  • The Stretch calculation needs to be faster

Acceptance criteria:

  • The BayesQuasi2 and BayesStretch2 algorithms have the same features as BayesQuasi and BayesStretch
  • The BayesStretch2 calculation completes within a reasonable time
@robertapplin robertapplin added Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS labels Apr 10, 2024
@robertapplin robertapplin modified the milestone: Release 6.11 Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS
Projects
Status: No status
Development

No branches or pull requests

1 participant