Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check if sample details exists before applying absorption correction in diffraction scripts #36017

Open
MohamedAlmaki opened this issue Sep 7, 2023 · 0 comments · May be fixed by #36809
Open

Add check if sample details exists before applying absorption correction in diffraction scripts #36017

MohamedAlmaki opened this issue Sep 7, 2023 · 0 comments · May be fixed by #36809
Assignees
@MohamedAlmaki
Labels
Diffraction Issues and pull requests related to diffraction ISIS Team: Diffraction Issue and pull requests managed by the Diffraction subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.

Comments

@MohamedAlmaki
Copy link
Contributor

Describe the outcome that is desired.

In the diffraction scripts, if you enable absorption correction without providing a sample_details object, the script may generate an error. It is recommended to include a check for the presence of sample details and to prompt the user with an appropriate error message if they are absent.

Describe any solutions you are considering

Add the check to the common focus function
@MohamedAlmaki MohamedAlmaki added Diffraction Issues and pull requests related to diffraction Maintenance Unassigned issues to be addressed in the next maintenance period. labels Sep 7, 2023
@MohamedAlmaki MohamedAlmaki mentioned this issue Sep 7, 2023
Merged
@MohamedAlmaki MohamedAlmaki self-assigned this Feb 2, 2024
@MohamedAlmaki MohamedAlmaki linked a pull request Feb 5, 2024 that will close this issue
Open
@sf1919 sf1919 added the ISIS Team: Diffraction Issue and pull requests managed by the Diffraction subteam at ISIS label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohamedAlmaki MohamedAlmaki

Labels
Diffraction Issues and pull requests related to diffraction ISIS Team: Diffraction Issue and pull requests managed by the Diffraction subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Mantid Maintenance
Status: In progress
Milestone
No milestone
2 participants
@MohamedAlmaki @sf1919